This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
P2p locking adjustments #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuommaki
commented
Mar 20, 2024
Comment on lines
+836
to
+837
| // Let the dust settle down a bit. | ||
| //tokio::time::sleep(std::time::Duration::from_secs(5)).await; |
There was a problem hiding this comment.
@musitdev in the current setting, if there's no wait / sleep between connects and transaction sends, this test locks up on my laptop. What happens is that those derivative new node connects are happening concurrently with the transaction sends and this causes the deadlock somehow.
If you uncomment this sleep and all the connects take place before the transaction sends, so far I couldn't reproduce the deadlock anymore.
|
Most of the testing here is now finished and there are no further actions in this branch. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.